search

ByMykel / CSGO-API

An unofficial JSON API for Counter-Strike 2 in multiples languages. List of skins, cases, stickers, collections, collectibles, agents, graffiti, keys, patches and music kits.
https://bymykel.github.io/CSGO-API/
MIT License
255 stars 29 forks source link

Small changes and fix for one item #120

Closed easton36 closed 1 month ago

easton36 commented 1 month ago

I changed all of the JSON import statements to use the keyword with instead of assert since that is the new valid keyword. Not sure which node version github workflow runs since I am not familiar with it.

I added color 6 (Tracer Yellow) for the item Sealed Graffiti | Recoil AUG because it didn't exist in the scripts. I am not sure how you know which colors each graffiti has, but I would like to know where you are getting that info from so we can make this more accurate.

ByMykel commented 1 month ago

Not sure which node version github workflow runs since I am not familiar with it.

Hi. The workflows run on node 18.

I added color 6 (Tracer Yellow) for the item Sealed Graffiti | Recoil AUG because it didn't exist in the scripts. I am not sure how you know which colors each graffiti has, but I would like to know where you are getting that info from so we can make this more accurate.

I added all the sealed graffiti checking csmoney wiki, but seems like they don't have all the colors.

After adding them to the script I have to add the images to this repo.

I haven't found a way to automate all of this. You can check the discussion about this here: https://github.com/ByMykel/CSGO-API/discussions/109

BTW I can't check the changes as you might pushed all the JSON files: image

easton36 commented 1 month ago

My bad. This is the only important change: https://github.com/ByMykel/CSGO-API/pull/120/commits/c0d8be94c55efd4a6dd5441a9f0eb9d09668ca83

ByMykel commented 1 month ago

My bad. This is the only important change: c0d8be9

Do you mind removing you last commit and leaving only the Sealed Graffiti change?

easton36 commented 1 month ago

Done, sorry for the late reply