search

ByMykel / CSGO-API

An unofficial JSON API for Counter-Strike 2 in multiples languages. List of skins, cases, stickers, collections, collectibles, agents, graffiti, keys, patches and music kits.
https://bymykel.github.io/CSGO-API/
MIT License
260 stars 31 forks source link

Skin ids don't match up and skins.json contains wrong information #27

Closed schuler-ph closed 1 year ago

schuler-ph commented 1 year ago

I downloaded skins and cases and tried to link cases.contains.obj.id with skins.obj.id, but it already fails at the Csgo Weapon Case. In the contains_rare prop of the case, there is the bayonet fade which has the id skin-200616, but in skins.json this id is the five seven berries and cherries and bayonet fade has id skin-32768152. Also i tried to test if the rarities in cases.json and skins.json match up and from what i've seen at least the glock dragon tattoo and m4a4 faded zebra have the wrong rarities in skins.json. M4a4 faded zebra is Mil-spec, not industrial grade and glock dragon tatto is restricted not mil-spec. This is only wrong in skins.json.

schuler-ph commented 1 year ago

Additionally, the doppler knives all link to the bayonet doppler, not to their own skin entry and vanilla knife variants are missing. So I cannot confidently use crates.json and link to skins.json because the id's don't match and I cannot use skins.json because the rarities are wrong. These are the information errors I have found there are definitely more.

ByMykel commented 1 year ago

@schuler-ph Thank you for reporting this bug. I don't use the API so there might the a lot of errors, so if you find more or you think some structure is not appropiate feel free to open an issue.

Additionally, the doppler knives all link to the bayonet doppler, not to their own skin entry

I don't understand this one.

I would separe this issue in:

I would try to fix all of this ASAP but I don't have much free time.

schuler-ph commented 1 year ago

@ByMykel I think I just misunderstood the Ids for the Doppler knives. So if you go to the Flip knife doppler phase 1 in the chroma case in crates.json it has the same id as just the bayonet doppler phase 1 in skins.json, despite it having its own entry and id in skins.json. If you look up the id of a flip knife doppler phase 1 from skins.json, it cannot be found in crates.json.

ByMykel commented 1 year ago

@schuler-ph Checking your example it seems like its fixed already.

ByMykel commented 1 year ago

@schuler-ph Vanilla knives added

ByMykel commented 1 year ago

@schuler-ph Fixed skin's rarities.