ByMykel / CSGO-API

An unofficial JSON API for Counter-Strike 2 in multiples languages. List of skins, cases, stickers, collections, collectibles, agents, graffiti, keys, patches and music kits.
https://bymykel.github.io/CSGO-API/
MIT License
260 stars 31 forks source link

New `skins_not_grouped.json` endpoint #43

Closed ByMykel closed 1 year ago

ByMykel commented 1 year ago

Working on #38

ByMykel commented 1 year ago

@RatzeR check the new endpoint skins_not_grouped.json. I tried to remove all the possible attributes, and if someone wants more info they can fetch by skin_id.

I have decided that is better to have this endpoint (skins_not_grouped.json) in all.json rather than skins.json so these API REST endpoints bellow could be used:

ByMykel commented 1 year ago

If I'm not missing something this should be done and resolves #38

RatzeR commented 1 year ago

Hi @ByMykel,

looks great! I just found one/two little things:

I think in case of a Stattrack or Souvenir the correct structure is:

Desert Eagle (Souvenir) | Urban Rubble (Factory New) and Desert Eagle (StatTrak™) | Hypnotic (Factory New)

The rest seems to be fine! :-)

I also really like the crates extension in the skin.json!

ByMykel commented 1 year ago

@RatzeR The translations are different in every language.

I have checked very fast all the languages and write them here utils/translations.json.

Desert Eagle (Souvenir) | Urban Rubble (Factory New) and Desert Eagle (StatTrak™) | Hypnotic (Factory New)

These are for German language and look equal to your example.

{
    "collectible_genuine": "{item_name} ({genuine})",
    "rare_special": "{item_name} (★) | {pattern}",
    "rare_special_with_wear": "{item_name} (★) | {pattern} ({wear})",
    "rare_special_with_wear_stattrak": "{item_name} (★ StatTrak™) | {pattern} ({wear})",
    "rare_special_vanilla": "{item_name} (★)",
    "rare_special_vanilla_stattrak": "{item_name} (★ StatTrak™)",
    "skin": "{item_name} | {pattern} ({wear})",
    "skin_stattrak": "{item_name} (StatTrak™) | {pattern} ({wear})",
    "skin_souvenir": "{item_name} (Souvenir) | {pattern} ({wear})"
}

BTW some translations could be not correct but and I'm not going to check double as there are many languages. I think is better to wait for people to open issues as is a quick fix. image