ByMykel / CSGO-API

An unofficial JSON API for Counter-Strike 2 in multiples languages. List of skins, cases, stickers, collections, collectibles, agents, graffiti, keys, patches and music kits.
https://bymykel.github.io/CSGO-API/
MIT License
240 stars 27 forks source link

Improve description for event, stattrak, ... #93

Open piyanggoon opened 5 months ago

piyanggoon commented 5 months ago

AK-47 | Redline

Powerful and reliable, the AK-47 is one of the most popular assault rifles in the world. It is most deadly in short, controlled bursts of fire.

to

Powerful and reliable, the AK-47 is one of the most popular assault rifles in the world. It is most deadly in short, controlled bursts of fire. It has been painted using a carbon fiber hydrographic and a dry-transfer decal of a red pinstripe. Never be afraid to push it to the limit

piyanggoon commented 5 months ago

Sticker | FURIA | Katowice 2019

50% of the proceeds from the sale of this sticker support the included players and organizations.

to

This item commemorates the 2019 IEM Katowice CS:GO Championship.

This sticker can be applied to any weapon you own and can be scraped to look more worn. You can scrape the same sticker multiple times, making it a bit more worn each time, until it is removed from the weapon.

50% of the proceeds from the sale of this sticker support the included players and organizations.

piyanggoon commented 5 months ago

Now pull request for pattern, but still missing on "CSGOEvent"

  "CSGO_Event_Desc"                           "This item commemorates the %s1."
  "CSGO_Event_Details_Desc"                   "It was dropped during the %s1 match between %s2 and %s3."
  "CSGO_Event_Details_MvpDesc"                "It was dropped during the %s1 match between %s2 and %s3, and autographed by %s4 who was the most valuable player in that round."
  "CSGO_Event_Details_MvpDesc_UnknownPlayer"  "It was dropped during the %s1 match between %s2 and %s3, and autographed by the professional player who was the most valuable player in that round."

Example.

This item commemorates the 2016 ESL One Cologne CS:GO Championship.

It was dropped during the Group Stage match between Flipsid3 Tactics and Ninjas in Pyjamas, and autographed by Yegor Markelov who was the most valuable player in that round.

ByMykel commented 5 months ago

Does your PR #96 fixes this issue?

piyanggoon commented 5 months ago

96 not include "CSGOEvent".

Here example item

CSGO_Event_Desc, CSGO_Event_Details_Desc Souvenir XM1014 | Blue Steel (Field-Tested)

CSGO_Event_Desc, CSGO_Event_Details_MvpDesc Souvenir Nova | Predator (Well-Worn)

And still missing desc on StatTrak, StatTrak™, ... try checking on steam market.

ByMykel commented 5 months ago

96 not include "CSGOEvent".

Here example item

CSGO_Event_Desc, CSGO_Event_Details_Desc Souvenir XM1014 | Blue Steel (Field-Tested)

CSGO_Event_Desc, CSGO_Event_Details_MvpDesc Souvenir Nova | Predator (Well-Worn)

And still missing desc on StatTrak, StatTrak™, ... try checking on steam market.

oh i see it. But this would be better used in skins_not_grouped.json. Because we can differentiate between normal, sourvenir and stattrak.

I don't have much free time, so feels free to open a PR adding this if you desire it