Peer-to-Peer Code Review Session

Byabasaija / positioning-and-floating-elements-project1

4 stars 0 forks source link

Peer-to-Peer Code Review Session #4

Open Andrik27001 opened 4 years ago

Andrik27001 commented 4 years ago

You can put down your reviews for the code below.

Andrik27001 commented 4 years ago

Work on the indentation of your code, it will look better and easier to read
Aside element is missing

Honda99 commented 4 years ago

It is good, except improper usage of class name like "headr-div1", width of video and images are not matched with the paragraph. You have forgotten the horizontal lines on the grid images.

apricot12 commented 4 years ago

Your project looks great for the most part, but some of the things that you could improve are :

You could've used different fonts and font sizes.
Your inflation image goes over your top nav bar. You can fix it using Z-index
You need to use an "aside" tag for the Editor's pick as part of the project requirements.
You could've tried to keep the embed video in constant 16:9 aspect ratio to match the rest of the elements