search

Byloth / cmangos-docker

⚔ A collection of ready-to-use Docker images to host your WoW emulated private server wherever you want.
GNU General Public License v2.0
22 stars 6 forks source link

Is there support for `AHBot` and `Playerbots`? #26

Open Stianos-hub opened 2 months ago

Stianos-hub commented 2 months ago

Hey,

I've gotten everything set up and the game running, but I've been struggling to get AH BOT and Playerbot turned on. Is there an easy way to do this?

Thanks!

Byloth commented 2 months ago

Hi, @Stianos-hub! Thanks for your interest into this project! 🙃

Actually, yes... There's a PR opened about it that can't be closed yet.

All the details here: https://github.com/Byloth/cmangos-docker/pull/20

I'm not sure about it but, to be precise... If you're not using the tbc version of the server, maybe you can run it up by your own just switching branch and building the Docker images by yourself.

Byloth commented 2 months ago

Any help for this PR is greatly appreciated and encouraged! 🥹

Stianos-hub commented 2 months ago

Hey, I"ll absolutely take a look. I'm attempting to get this working on classic, but I looking at the code it doesn't look to expansion specific. I see some places I missed some flips, going to try some changes and will post results!

Stianos-hub commented 2 months ago

Have you gotten them working on the TBC servers? I've added the changes from the PRs and set it to pull the development branch, but I'm still missing something to get the commands working in game.

Byloth commented 2 months ago

Have you gotten them working on the TBC servers?

No, I think it's still incompatible with the tbc version of the server.

TBH, I haven't tested it in the past few days; maybe something has changed.
I will try further, later this week.

Byloth commented 1 month ago

I just tried to compile the source code including the latest version of CMaNGOS Playerbots and it doesn't even complete properly.
It fails with a lot of errors; it probably wouldn't make sense to paste them here...

Answering your question, then...
No. tbc version of the server is still incompatible.

Stianos-hub commented 1 month ago

I was working on it this weekend, had to take a break for my real job, but I found that the command changed names for cmake, I was going to try and reincorporate what I learned next chance I get. Biggest things I found were: The command is actually DBUILD_PLAYERBOTS (With an S!) image

Running with a relative file path causes issues, and it's better to run it from the working directory. image

That plus making sure the FullInstallDb.sh runs the commands to add the playerbot tables was what got it working for me on classic.

Once I find time I wanted to back incorporate this into the docker files and see if I can get it to work.

Hopefully some of this helps if you want to try and incorporate it into tbc before I get a chance to make some changes

Byloth commented 1 month ago

Yeah... No worries! 😉

I would say that's already like this:

  1. https://github.com/Byloth/cmangos-docker/blob/f425e4707e2d3f2e9a877253cc7058cf48cb51ef/Dockerfile#L111
  2. https://github.com/Byloth/cmangos-docker/blob/f425e4707e2d3f2e9a877253cc7058cf48cb51ef/runner/entrypoint.sh#L159
Byloth commented 1 month ago

Take a look also to this conversation...

https://discord.com/channels/362206349339262976/1280194808048259102/1283185344631668847

Stianos-hub commented 1 month ago

Well you were certainly ahead of me then! I'll try and catch up so hopefully I can contribute something useful!

Byloth commented 2 weeks ago

@draew6: I just tested playerbots on tbc (using the feature/bots branch) and it worked fine.

draew6 commented 2 weeks ago

 @Byloth I changed branch and did docker compose up     ✘ mangosd Error pull access denied for byloth/cmangos-tbc, repository does not exist or may require 'docker login' 1.2s ✘ realmd Error context canceled

Byloth commented 2 weeks ago

Yeah, sorry... My bad! Since this branch isn't production ready, no images are built automatically.

You have to build it by yourself.

Use...

./cmangos-build.sh --help

... for more details! 😉

draew6 commented 2 weeks ago

@Byloth I had to build 2 images and it took long time but it was worth it! it's working and bots are living their dream :D didnt test anything specific yet, just interacted with them for 30 minutes but I think any other problems with them would be out of scope of this project so I think it works as expected from my side! thanks for your contribution and instructions (y)

Byloth commented 2 weeks ago

Awesome, @draew6! 🤩

[...] it took long time but it was worth it!

Yeah... CMaNGOS takes a lot of time to build! 🥲 Using multiple threads, accordingly to your hardware, might help!

[...] but I think any other problems with them would be out of scope of this project [...]

Not necessarily, actually... 🤔
May I ask you if you can report here or here any future issues or additional steps / configurations you might need in the future to improve your experience?

This could also help improve the future documentation about bots, configuration process and so on...

Thanks!

Byloth commented 2 weeks ago

I'm going to lock this conversation.
All the information you need is already here, IMHO.

From now on, please refer to the PR for the status of "Bot support" and Discussion if you have any questions or concerns.
This issue will be closed as soon as the related PR is merged.

Thank you all for your interest in this project! ❤️