search

Bynder / bynder-c-sharp-sdk

SDK in C# for integration with Bynder
MIT License
3 stars 23 forks source link

Simplified Asset Service to use Stream instead of FileStream #104

Closed VGrigoriev1991 closed 1 month ago

VGrigoriev1991 commented 1 month ago

Simplified AssetService to use Stream instead of FileStream for file uploading since only the Stream base type is used further.

AssetService uses FileUploader for file uploading. FileUploader expects Stream as first input parameter type when AssetService expects FileStream as first input parameter type. AssetService doesn't use any features of the FileStream and can be simplified to use Stream as an first input parameter type.

This change should be useful in case of using Bynder SDK in clouds for serverless applications when there are limits on available disk space (for FileStream it's necessary to have file on the disk).

coveralls commented 1 month ago

Coverage Status

coverage: 53.518%. remained the same when pulling 84f7091346567e6b4b291f6e334243a9ca8655e1 on VGrigoriev1991:asset-service-upload-file-stream into 0324ec69f6a6e414cde84414b61a5e17c06d3efe on Bynder:master.