search

Bynder / bynder-c-sharp-sdk

SDK in C# for integration with Bynder
MIT License
3 stars 23 forks source link

Using Stream instead of FileStream to upload assets #105

Open VGrigoriev1991 opened 1 day ago

VGrigoriev1991 commented 1 day ago

The current implementation of SDK does not allow using a Stream instead of a FileStream to upload assets using AssetService.

The AssetService itself does nothing with the FileStream input parameter and passes it to the FileUploader, which expects the basic Stream type as input.

This functionality is very necessary when using SDK in clouds for serverless applications, when there are limits on available disk space. To use the FileStream, you must have the file directly on the disk.

The SDK is also designed in such a way that it is not possible to expand functionality of BynderClient/AssetService or use a FileUploader separately for uploading assets.

I'm suggesting a potential small change that I've already submitted as a pull request - https://github.com/Bynder/bynder-c-sharp-sdk/pull/104.

Thanks in advance for your attention.

ahongbynder commented 21 hours ago

@VGrigoriev1991 merged your PR, will setup a release either next week or later.