search

Bynder / bynder-c-sharp-sdk

SDK in C# for integration with Bynder
MIT License
3 stars 23 forks source link

fixed issue with use of relative url's #60

Closed kunalshetye closed 3 years ago

kunalshetye commented 3 years ago

If you are accessing bynder behind an API Gateway or a Proxy then the relative urls for API Calls are not combined properly.

Example BaseUrl: https://test.company.com/bynder UrlPath: /api/v4/example Expected http call: https://test.company.com/bynder/api/v4/example Actual http call: https://test.company.com/api/v4/example

It was assumed to be fixed in the latest version of the SDK but unfortunately that's not the case :(

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.1%) to 46.991% when pulling e7837744d6199749ea54be899f40b91afcef8459 on kunalshetye:bugfix/relative-urls-issue into d2a3e61d0cc3ef1bae9fb1c7015b98e1cdb2d7d4 on Bynder:master.

githuib commented 3 years ago

Hi @kunalshetye, thanks for your pull request. I've generalized it into an extension method and applied it to the OAuthService. I chose to make a separate pull request because it differs a bit too much from yours in terms of where code is put (but the actual business logic is the same): https://github.com/Bynder/bynder-c-sharp-sdk/pull/61

I hope it will work for you, but please let me know if that isn't the case.

kunalshetye commented 3 years ago

Yeah. That should work indeed. You can decline my PR and go ahead with the one from you.

githuib commented 3 years ago

We've just deployed the other pull request, so the package (v 2.2.7) should appear on NuGet in any moment.