search

Bynder / bynder-c-sharp-sdk

SDK in C# for integration with Bynder
MIT License
3 stars 23 forks source link

v3-find-assets #96

Closed quirijnslings closed 1 month ago

quirijnslings commented 2 months ago

Please merge v3-platform first

New features:

Test interactively with FindMediaSample, MediaSample and unit test with AssetServiceTest.

quirijnslings commented 2 months ago

Fixed merge conflicts

quirijnslings commented 2 months ago

Hi @ahongbynder I combined the last 2 remaining PRs into this one to avoid any more merge conflicts. I've closed v3-upload.

Also, I noticed the samples did not cover the new ways of searching for assets, especially by metaproperty name and option. I created a new sample class called FindMediaSample for this. It searches in three ways:

The first 2 should always give the same number of results, the third one might yield more results because the word(s) you search for might occur in other properties as well of course.

Also, I noticed one of the unit tests was failing. I fixed that as well, see last commit.

ahongbynder commented 2 months ago

@quirijnslings Just have a couple minor comments. After merging before the release can be created, need to fix the github actions used in release process. Have reached out internally to look at it.

ahongbynder commented 1 month ago

@quirijnslings Merged in your changes, have this PR to fix GitHub actions and update dotnet version for tests https://github.com/Bynder/bynder-c-sharp-sdk/pull/101. We have a release freeze next week so publishing your changes for V3 is dependent on the actions fixed and after our release freeze.