Bynder / bynder-java-sdk

SDK in Java for integration with Bynder
MIT License
4 stars 24 forks source link

Implementation of Workflow API #100

Closed alfnav closed 1 year ago

alfnav commented 1 year ago

Full implementation of the Bynder Workflow API:

coveralls commented 1 year ago

Coverage Status

Coverage: 56.341%. Remained the same when pulling e776009db2f251135374ae3bf911c431bd42aadd on alfnav:workflow into 170a5643b6320cac41ac11ecdc069b60c05861a7 on Bynder:master.

TimBloembergen commented 1 year ago

Thanks @alfnav. We will review this PR and will keep you posted on what we will do with it.

TimBloembergen commented 1 year ago

Hi @alfnav could you please review @Arpit-Sharma-USC 's comments and add the changes requested? We would like to merge these new features and make a new release this week. Thanks!

alfnav commented 1 year ago

Hello @TimBloembergen , I am so sorry for the delay in come back to you, I was quite busy at work and i could not find time to do the required changed. Meanwhile I can see that @Arpit-Sharma-USC has already done some of the formatting and documentation changes, sorry for not including this at the beginning. I think that there are also some extra documentation which can be added in the bynder API class and I can do that at a later stage together with other changes in the SDK which I will push if this is ok for you. Thanks!

TimBloembergen commented 1 year ago

Hi @alfnav No worries at all, I indeed asked if Arpit could do the changes so we're not blocked for a release. We really appreciate the work and effort you put into this. I believe this is the biggest contribution someone has ever done on any of our SDK's. We will create a new release, if you want to add more documentation to it we would appreciate it so we can merge that at a later stage.