Do not throw exceptions on API 204 No Content responses without a Content-Type header

Bynder / bynder-php-sdk

SDK in PHP for integration with Bynder

MIT License

14 stars 22 forks source link

Do not throw exceptions on API 204 No Content responses without a Content-Type header #52

Closed davereid-pfg closed 1 year ago

davereid-pfg commented 2 years ago

The response from https://bynder.docs.apiary.io/#reference/asset-usage/asset-usage-operations/delete-asset-usage is a HTTP 204 code with no Content-Type header at all provided in the response. This causes an exception to be thrown when using the PHP SDK.

davereid-pfg commented 2 years ago

I actually think this is a bug in the API itself that the following Delete-operation APIs return a 204 response without a Content-Type header:

coveralls commented 1 year ago

Coverage decreased (-0.3%) to 43.168% when pulling 69ee1a28710625864fcfc06122bec4208fb98c3f on davereid-pfg:patch-2 into 8838ecaa7da43c2820bfd36c344d505948d190ae on Bynder:master.

coveralls commented 1 year ago

Coverage decreased (-0.3%) to 43.168% when pulling 69ee1a28710625864fcfc06122bec4208fb98c3f on davereid-pfg:patch-2 into 8838ecaa7da43c2820bfd36c344d505948d190ae on Bynder:master.