search

Bynder / bynder-python-sdk

SDK in Python for integration with Bynder
MIT License
8 stars 12 forks source link

`asset_bank_client.upload_file` does not return anything #3

Closed ilkka closed 6 years ago

ilkka commented 6 years ago

I was a bit surprised by this and first thought my uploads were failing silently. They did in fact succeed, and it seems that the reason upload_file does not return anything is that UploadClient._save_media doeos not return anything. It just defines a local variable save_success that is not used for anything.

How can I identify the asset after upload if upload_file does not return anything?

fnavarrogonzalez commented 6 years ago

Hi @ilkka,

You are right we should return at least the mediaid. You can see the minimal needed modifications in https://github.com/Bynder/bynder-python-sdk/pull/4 for make it working until we fix it.

fnavarrogonzalez commented 6 years ago

It's merge. You receive now a dict with a key 'mediaid' included that you can use. I'm closing this. Reopen or create a new issue if you still having issues.

ilkka commented 6 years ago

That was fast, thanks! 👌🏻

Francisco Navarro notifications@github.com kirjoitti 5.1.2018 kello 16.55:

It's merge. You receive now a dict with a key 'mediaid' included that you can use. I'm closing this. Reopen or create a new issue if you still having issues.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.