Bynder / gathercontent-htmldiff

Compare two HTML strings
MIT License
11 stars 6 forks source link

Remove dependency on Tidy PECL extension #1

Open acairns opened 10 years ago

acairns commented 10 years ago

At the moment, there is a dependency upon the Tidy pecl extension: https://github.com/gathercontent/htmldiff/blob/master/src/Gathercontent/Htmldiff/Htmldiff.php#L48

Suggest removing this in favour of a dependency which can be managed via composer.

legierski commented 10 years ago

"require": { "php": ">=5.3.0", "ext-tidy": "*"

},

?

On 12 March 2014 19:05, Andrew Cairns notifications@github.com wrote:

At the moment, there is a dependency upon the Tidy pecl extension:

https://github.com/gathercontent/htmldiff/blob/master/src/Gathercontent/Htmldiff/Htmldiff.php#L48

Suggest removing this in favour of a dependency which can be managed via composer.

— Reply to this email directly or view it on GitHubhttps://github.com/gathercontent/htmldiff/issues/1 .

Peter Legierski

peter@legierski.net http://legierski.net +44 7903 106 956

acairns commented 10 years ago

Can't we replace it with another package? Or have it as a suggestion and pass it in as a driver?

legierski commented 10 years ago

Not quite sure if there's another package that would do the job well. Tidy seems to be a standard. I like the idea of having it as a suggestion and pass driver.

On 12 March 2014 19:18, Andrew Cairns notifications@github.com wrote:

Can't we replace it with another package? Or have it as a suggestion and pass it in as a driver?

— Reply to this email directly or view it on GitHubhttps://github.com/gathercontent/htmldiff/issues/1#issuecomment-37451864 .

Peter Legierski

peter@legierski.net http://legierski.net +44 7903 106 956

gajus commented 10 years ago

Depending on what you are looking to Tidy, consider https://github.com/gajus/dindent. Came across this topic while researching a similar issue.