search

ByoxCode / DrawView

Android view that allows the user to create drawings. Customize settings like color, width or tools. Undo or redo actions. Zoom into DrawView and add a background.
848 stars 155 forks source link

Eraser mode clears background #25

Open thanhpd56 opened 6 years ago

thanhpd56 commented 6 years ago

Hi, Thanks for your great library. It's awsome. However i have an isssue that is when i change to eraser mode, it also clears background image. How can i prevent this? Thanks.

ByoxCode commented 6 years ago

Hi @thanhpd56 !!!

God point! I can add a configuration to exclude background from eraser, wait for the update please

thanhpd56 commented 6 years ago

Hi @ByoxCode , Thanks for your response. Is there any plan for the next release?

ByoxCode commented 6 years ago

Sure, I'm working in a major update. Please wait for the next release. I'm planning changes for camera option, add more shapes, and in the snapshot branch I already added a improvement to load a background from remote image (url)

thanhpd56 commented 6 years ago

Amazing! Thanks.

On Fri, Jul 13, 2018, 07:43 Oscar Gilberto Medina Cruz < notifications@github.com> wrote:

Sure, I'm working in a major update. Please wait for the next release. I'm planning changes for camera option, add more shapes, and in the snapshot branch I already added a improvement to load a background from remote image (url)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ByoxCode/DrawView/issues/25#issuecomment-404692120, or mute the thread https://github.com/notifications/unsubscribe-auth/ADnn0kQ8z0i0pFVR3g1OgFIdB8_sD2rNks5uF-0igaJpZM4UoDvF .

ByoxCode commented 6 years ago

Hey @thanhpd56!! I released a snapshot version for new changes, you can see how to implement it in README.md

thanhpd56 commented 6 years ago

Woah, great work! I will try it, and tell you the result soon.

thanhpd56 commented 6 years ago

Hi @ByoxCode, I try to import new snapshot version but it failed. maven { url "https://raw.githubusercontent.com/ByoxCode/DrawView/snapshot/aar/snapshots/" } `` implementation 'com.byox.drawview:drawview:1.3.1-SNAPSHOT' Unable to resolve dependency for ':app@prodFullDebug/compileClasspath': Could not resolve com.byox.drawview:drawview:1.3.1-SNAPSHOT.

What should i do?

thanhpd56 commented 6 years ago

Oh, It should be 1.0.0-SNAPSHOT. By the way, you changed api alot. @@

thanhpd56 commented 6 years ago

@ByoxCode Now it's working well. However, when i save image the background image is gone, only draw path.

ByoxCode commented 6 years ago

@thanhpd56 really? Well I check this again, thanks!

thanhpd56 commented 6 years ago

@ByoxCode One more problem, that mentioned from this. It still happens in this version. You can produce this issue by open drawview, then press home so that application turns to background => Crash. The solution is creating new class extends original graphic Matric and also implements Serializable. Thanks, wait for new update.

ibrahimsu commented 5 years ago

This line

mDrawView.setBackgroundImage(bitmap,BackgroundType.BITMAP,BackgroundScale.FIT_START); Change to : 

  Drawable drawable = new BitmapDrawable(getResources(), bitmap);
                        mDrawView.setBackground(drawable);

But problem is , when click save, background not save :( any help @ByoxCode @thanhpd56