Byron / cargo-smart-release

Release complex cargo-workspaces automatically with changelog generation, used by `gitoxide`
Apache License 2.0
74 stars 6 forks source link

`[build-dependencies]` don't get tracked as needing publishing, don't get published first as needed #16

Open MingweiSamuel opened 7 months ago

MingweiSamuel commented 5 months ago

A very naive grep through the code points to this line maybe being relevant https://github.com/Byron/cargo-smart-release/blob/d472a8db86003c9e6caa10a53c7e021f7f062b60/src/traverse.rs#L529

Byron commented 5 months ago

You can probably try that locally in a project that would need it. It's also the only place that seems to filter by kind, so I'd say it's indeed promising.

MingweiSamuel commented 3 months ago

Seems like it might be an issue with [dev-dependencies] as well (not being accounted for in the topological sort)

Byron commented 3 months ago

dev-dependencies that are also in the workspace must use { path = "<path-to-crate>" } without mentioning any version. Otherwise it definitely breaks.