Cargo.lock issue

[mexus]

Hi @Byron! Thanks for including the Cargo.lock file in the release! Although there's a small issue about it: the crate's version in Cargo.lock doesn't match one in the Cargo.toml (2.1.3 and 2.1.4 respectively), which effectively prevents building the crate with the --locked flag :( Could you please maybe check somehow that cargo build doesn't modify the git root? This will help to ensure that the up-to-date version of Cargo.lock is released :)

Thanks!

[ghost]

Wow! This is tricky, and the first time these went out of sync. To me it seems more like a bug that cargo publish will indeed update the cargo lock, but won't complain about the now dirty working tree, nor will it pick up the version it wrote. The most recent v2.1.5 should do the job :D!

On Wed, Jul 3, 2019 at 3:00 AM Denis notifications@github.com wrote:

Hi @Byron https://github.com/Byron! Thanks for including the Cargo.lock file in the release! Although there's a small issue about it: the crate's version in Cargo.lock doesn't match one in the Cargo.toml (2.1.3 and 2.1.4 respectively), which effectively prevents building the crate with the --locked flag :( Could you please maybe check somehow that cargo build doesn't modify the git root? This will help to ensure that the up-to-date version of Cargo.lock is released :)

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Byron/dua-cli/issues/20?email_source=notifications&email_token=ADTXPGV7FHEFKQYJ34Y4LXTP5OQVJA5CNFSM4H4645IKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G46XC2Q, or mute the thread https://github.com/notifications/unsubscribe-auth/ADTXPGR3MLJWU55NSV7A37LP5OQVJANCNFSM4H4645IA .

-- Sebastian Thiel 李乐乐 Rust and TWU Advocate Email sthiel@thoughtworks.com Telephone +49 (0) 40 300 95 880 <+49+(0)+40+300+95+880> [image: ThoughtWorks] http://www.thoughtworks.com/?utm_campaign=sebastian-thiel-signature&utm_medium=email&utm_source=thoughtworks-email-signature-generator

ThoughtWorks Deutschland GmbH Großer Burstah 46-48D-20457 Hamburg Sitz der Gesellschaft: Hamburg Geschäftsführer: Dr. Peter Buhrmann - AG Hamburg - HRB 115336

[mexus]

I actually agree that it seems like a bug in cargo, especially since it publishes the lock file for binary crates. I'll open an issue there when I get to my PC (hope I won't forget to).

Thanks for fixing the issue though! :)

On Wed, Jul 3, 2019, 9:25 AM Sebastian Thiel notifications@github.com wrote:

Wow! This is tricky, and the first time these went out of sync. To me it seems more like a bug that cargo publish will indeed update the cargo lock, but won't complain about the now dirty working tree, nor will it pick up the version it wrote. The most recent v2.1.5 should do the job :D!

On Wed, Jul 3, 2019 at 3:00 AM Denis notifications@github.com wrote:

Hi @Byron https://github.com/Byron! Thanks for including the Cargo.lock file in the release! Although there's a small issue about it: the crate's version in Cargo.lock doesn't match one in the Cargo.toml (2.1.3 and 2.1.4 respectively), which effectively prevents building the crate with the --locked flag :( Could you please maybe check somehow that cargo build doesn't modify the git root? This will help to ensure that the up-to-date version of Cargo.lock is released :)

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/Byron/dua-cli/issues/20?email_source=notifications&email_token=ADTXPGV7FHEFKQYJ34Y4LXTP5OQVJA5CNFSM4H4645IKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G46XC2Q , or mute the thread < https://github.com/notifications/unsubscribe-auth/ADTXPGR3MLJWU55NSV7A37LP5OQVJANCNFSM4H4645IA

.

-- Sebastian Thiel 李乐乐 Rust and TWU Advocate Email sthiel@thoughtworks.com Telephone +49 (0) 40 300 95 880 <+49+(0)+40+300+95+880> [image: ThoughtWorks] < http://www.thoughtworks.com/?utm_campaign=sebastian-thiel-signature&utm_medium=email&utm_source=thoughtworks-email-signature-generator

ThoughtWorks Deutschland GmbH Großer Burstah 46-48D-20457 Hamburg Sitz der Gesellschaft: Hamburg Geschäftsführer: Dr. Peter Buhrmann - AG Hamburg - HRB 115336

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Byron/dua-cli/issues/20?email_source=notifications&email_token=AA3RGDNT3HQOX66BJHB7CGTP5RA5HA5CNFSM4H4645IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZDNCHI#issuecomment-507957533, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3RGDM2JNXU3EZ3X7USV2LP5RA5HANCNFSM4H4645IA .

[mexus]

Thanks for solving the issue that fast! I guess we can safely close the issue, unless you want to implement some kind of an automatic check if --locked actually works ;)

[ghost]

Thanks for the hint! For now I will remember the 'Cargo.lock out of sync' issue, after all I believe cargo publish should be able to catch it.