Cursor line not visible with NO_COLOR

Byron / dua-cli

View disk space usage and delete unwanted data, fast.

https://lib.rs/crates/dua-cli

MIT License

4.17k stars 113 forks source link

Cursor line not visible with NO_COLOR #238

Open samuelallan72 opened 7 months ago

samuelallan72 commented 7 months ago

when I have NO_COLOR=true in the environment, dua i won't display the cursor line:

1713397567

It also seems to appear when I press C to display file count:

1713397799

But even then, sometimes it displays the cursor line when moving up, but disappears when moving down.

It works fine if I:

unset NO_COLOR
dua i

Byron commented 7 months ago

Thanks for letting me know!

It has never been tested with no-color, and I am surprised it even respects it. Further, it's nice to see that it is so close to actually working.

A solution might be to slightly change the style once no-color is detected.

samuelallan72 commented 7 months ago

Nice, yes I think a lot of low level tui libraries support NO_COLOR. :)

I usually run a light theme with NO_COLOR, so often hit edge cases with these things. :joy: Please let me know if there's anything you'd like tested more from a NO_COLOR or light theme environment, I'm happy to help out.