Byron / dua-cli

View disk space usage and delete unwanted data, fast.
https://lib.rs/crates/dua-cli
MIT License
3.67k stars 102 forks source link

move to trash - IO deletion error #245

Open h1ght opened 1 month ago

h1ght commented 1 month ago

hello,

i just found your programm and im pleased by it. but ctrl+t/rm-trash doenst seem to work?

#1 SMP PREEMPT_DYNAMIC Debian 6.6.13-1~bpo12+1 (2024-02-15)

deletion

trash-cli is installed via apt. fresh rust installation.

regards

Byron commented 1 month ago

That's great to hear!

An IO error means that the deletion failed typically due to permission errors. trash-cli also isn't used, the as the trash crate is used directly.

Closing, as I don't think this issue is actionable, but please feel free to add comments indicating what dua should do differently here.

h1ght commented 1 month ago

hm ive tested it again. on my ext4 partition it works. on this zfs pool it dont. but trash-cli works and moves the files into .Trash-1000/files e.g. ive looked up file ownership and permissions. this should not be the case. but im to dumb to find out on my own why this isnt working. //edit hmm this folder were it doenst work is dataset-volume within the main pool. in the main dua i works to move to trash, but not in the sub-pool. regards

Byron commented 1 month ago

It's likely that the files also can't be deleted from the trash then - permissions may allow to move them, but still prevent deletion.

A good test is also to use rm <filepath> - it will fail just like dua if permissions are an issue.

h1ght commented 1 month ago

permissions are not the issue, rm/trash-cli dont have any problems in the child dataset. only dua i got this error in the child dataset.

chris@debian-server:~$ zfs list
NAME                USED  AVAIL  REFER  MOUNTPOINT
storage-zfs        14.6T  7.06T  1.37G  /storage-zfs
storage-zfs/Apps    120K  7.06T   120K  /storage-zfs/Apps
storage-zfs/Games   873G  7.06T   873G  /storage-zfs/Games
storage-zfs/media  13.8T  7.06T  13.8T  /storage-zfs/media

i can move to trash via dua in /storage-zfs, but not in /storage-zfs/media or any other child dataset of storage-zfs.

Byron commented 1 month ago

trash-cli does the same that dua does when deleting single files, but there may be a difference in order when deleting directories. It's hard to say what's really happening here though without a clear description of what was tried in trash-cli that works and that doesn't work in dua.

This makes the issue about trashing behaviour though, and not about permission issues which are nothing the application can do anything about.

h1ght commented 1 month ago

i fiddled a bit more with it, installed rust in the root account and started dua with the root account. i can trash stuff in the child dataset now. a bit of a strange behaviour. now ive to find out how to install rust stuff systemwide.