search

Byron / dua-cli

View disk space usage and delete unwanted data, fast.
https://lib.rs/crates/dua-cli
MIT License
4.19k stars 113 forks source link

Ctrl + r doesn't work in interactive mode #33

Closed ms747 closed 4 years ago

ms747 commented 4 years ago

As the title suggests after marking files, Ctrl + r has no effects (deleting). Tried both release version and cargo compiled version.

Byron commented 4 years ago

Does it keep being an issue if you follow these steps?

Select something with space or d…

Screenshot 2020-02-22 at 09 46 08

…then hit the \ key…

Screenshot 2020-02-22 at 09 46 19

…and now hitting ctrl+r will work as advertised.

The process is intentionally forcing the user to perform multiple steps to make accidental deletion less likely.

If this doesn't fix your issue it may be a bug, which is when you can provide clear steps to reproduce it and we can reopen the issue.

Hope that helps.

pergamomo commented 1 year ago

Hi!

First of all thank you for a really nice tool!

I sort of ran into the same issue but only by finding this thread I figured out how to delete the selected files.

Maybe it would be an idea to show a hint in the yellow text field at the top or write it as the first bullet point in the help text.

Just a suggestion.

Byron commented 1 year ago

Yes, I think that could be a simple improvement with a lot of potential to reduce initial confusion on how to delete files.

Would you like to help with that? It's src/interactive/widgets/help.rs that would need an adjustment.

sommerper commented 1 year ago

@Byron Sure, I'll do it. (Just not with my work account from above) ;-)

sommerper commented 1 year ago

@Byron I'd like to commit a branch for review.