Byron / dua-cli

View disk space usage and delete unwanted data, fast.
https://lib.rs/crates/dua-cli
MIT License
4.19k stars 113 forks source link

Unsure about 'quit without delay from interactive mode' #55

Closed ngirard closed 4 years ago

ngirard commented 4 years ago

I'm afraid I don't understand what the following changelog entry for the newest 2.6.1 version means:

quit without delay from interactive mode after having looked at big directory trees

I tried to locate the related commit but didn't succeed. Would you mind adding a few explanations ?

Thanks !

Byron commented 4 years ago

Thanks for letting me know. I have updated the changelog, and also linked the corresponding commit which sometimes says more than a thousand words.

In short, dua will now always exit instantly from interactive mode - previously there may have been delays due to having to wait for deallocating a potentially massive hashmap, i.e. for millions of deallocations.

Please feel free to comment on the closed issue.

ngirard commented 4 years ago

Aah, I got it not, thank you very much ! Indeed, linking to the commit also allows me to learn from your code. Cheers!