No major design changes along the lines discussed in #1578 seemed like a decisive improvement; all of them had significant disadvantages. This instead:
Makes configure_command take anything we can iterate to get arguments, rather than requiring a &[String]. This makes the current test simpler and easier to read, and should also help with future tests.
Comments about how we don't heed env and env_remove calls on the Command object where "MSYS" is the key, since we take it from our environment directly and modify that.
There's slightly more thoughts in the commit messages. Also, I had trouble articulating why I thought 0e1e6a9 might be better here, since I don't usually prefer the more compact style, so maybe it's better without that change.
No major design changes along the lines discussed in #1578 seemed like a decisive improvement; all of them had significant disadvantages. This instead:
configure_commandtake anything we can iterate to get arguments, rather than requiring a&[String]. This makes the current test simpler and easier to read, and should also help with future tests.envandenv_removecalls on theCommandobject where"MSYS"is the key, since we take it from our environment directly and modify that.There's slightly more thoughts in the commit messages. Also, I had trouble articulating why I thought 0e1e6a9 might be better here, since I don't usually prefer the more compact style, so maybe it's better without that change.