search

Byron / google-apis-rs

A binding and CLI generator for all Google APIs
http://byron.github.io/google-apis-rs
Other
1.01k stars 131 forks source link

Match version of hyper-rustls used by yup-oauth2 8.2.0 #427

Closed mihirsamdarshi closed 1 year ago

mihirsamdarshi commented 1 year ago

I ran cargo update in my crate and I noticed I was getting compile errors due to the versions of hyper-rustls used by the generated API crates don't match the version of hyper-rustls used by the yup-oauth2 crate version 8.2

Byron commented 1 year ago

Thanks a lot for bringing this up!

It seems that yup-oauth2 incremented its minor version which contained (breaking) upgrades to hyper-rustls. Thus, cargo-update picked it up even though it ends up breaking in a program that still uses an older version of hyper-rustls.

So it seems that patch release of the common crate will fix this for everyone who has the latest yup-oauth2, but will break everybody else who doesn't use the latest. On the bright side, this case shouldn't really happen as cargo update would update everything at once, so… should be safe 🙏.

Byron commented 1 year ago

Actually, I changed my mind and instead released google-apis-common that pins the yup-oauth2 version to 8.1, which comes with the correct version of hyper-rustls. As cargo update won't upgrade breaking releases, cargo update should do the right thing in future.