search

Byron / google-apis-rs

A binding and CLI generator for all Google APIs
http://byron.github.io/google-apis-rs
Other
1.01k stars 131 forks source link

Add Debug derive to youtube3::api::Scope enum #450

Closed OMGeeky closed 10 months ago

OMGeeky commented 10 months ago

Adding that makes logging and debugging easier.

OMGeeky commented 10 months ago

I honestly don't really know how to build all things (and if I should?) but even if I should, it generates me a ton of changes with whitespace/line endings so if those should not be committed too I can't really generate it all since I would have to manually select the actual changes on each file etc.

If you got anything I should do differently feel free to tell me.

I also have no Idea why the check failed, maybe you can give me a hint for that one since it worked locally.

OMGeeky commented 10 months ago

I did (or at least think I did) change the generator file that is at src/generator/templates/api/lib/lib.mako. Btw for me at least the link you sent does not work. This PR should include 2 files, one is the generated one with make youtube3 and the other one is the template for it. Should I remove the generated one from the PR or is that fine?

Maybe while were at it we could also add the Clone derive to it since I don't see a reason why it should not be cloneable and the Enum does not contain any data that might not be cloneable

Byron commented 10 months ago

Apologies, I only saw the first line which was a generated file and stopped there.

Should I remove the generated one from the PR or is that fine?

Yes, please do remove the changes in the generated file do feel free to add more traits now that we are at it.

The link also doesn't work for me, strangely enough, but it has no value as it just linked to the generator which you are already aware of.

Thanks again.

Byron commented 10 months ago

Thanks a lot!

I added even more traits before merging.