search

Byron / google-apis-rs

A binding and CLI generator for all Google APIs
http://byron.github.io/google-apis-rs
Other
983 stars 132 forks source link

Add support for Spanner #485

Closed IvanUkhov closed 3 months ago

IvanUkhov commented 3 months ago

Hello,

Here are the changes needed for Spanner to be generated and successfully tested.

I am not sure what the protocol is. Should I include the generated package into the same PR? But then it looks like the generated bindings are outdated with respect to the JSON files in the repository (probably also related to #482), and the JSON files in the repository are outdated with respect to the official reference. It would be nice to bring everything up to seed. I can do that separately if you want.

Closes #484.

IvanUkhov commented 3 months ago

Added Spanner to etc/api/api-list_travis.yaml. Please take a look at the output. (By the way, it is no longer Travis; one should probably clean up and rename what is left from the time when it was in use. There is .travis.yml etc. I can do that.)

Also opened a PR updating the JSON files; see #488.

And to make your releasing easier, I can also volunteer to regenerate what is in gen in a separate PR.

Byron commented 3 months ago

Thanks for the update!

[..] By the way, it is no longer Travis; one should probably clean up and rename what is left from the time when it was in use. There is .travis.yml etc. I can do that.[..]

Thanks, that would be great!

All looks good now! And I hope more APIs can be activated now that the type-generator has been improved.