Byron / open-rs

Open a path or URL with the system-defined program
http://byron.github.io/open-rs
MIT License
319 stars 49 forks source link

Fix open::with() on Windows. (#80) #82

Closed igdswzcd closed 1 year ago

igdswzcd commented 1 year ago

On Windows OS, my colleagues and I conducted tests and found that:

At last, I modified the test code in main.rs. On Windows, you can call open::with() by using open.exe path -w app without specifying an env variable.

Byron commented 1 year ago

Thanks a lot for looking into this! I truly hope that this will be it now for Windows, and that it doesn't break in subtle, unforeseen ways.

I have created a new breaking release just to be sure this change doesn't catch anyone off-guard.