search

Byron / trash-rs

A Rust library for moving files to the Recycle Bin
MIT License
168 stars 28 forks source link

Test suite failing on armel architecture (no `AtomicI64` in `sync::atomic`) #99

Closed tenzap closed 8 months ago

tenzap commented 8 months ago

Your package has entered Debian, however while running the test suite on armel architecture they fails with this error:

285s    Compiling trash v3.2.1 (/usr/share/cargo/registry/trash-3.2.1)
285s      Running `CARGO=/usr/bin/cargo CARGO_CRATE_NAME=trash CARGO_MANIFEST_DIR=/usr/share/cargo/registry/trash-3.2.1 CARGO_PKG_AUTHORS='Artur Kovacs <kovacs.artur.barnabas@gmail.com>' CARGO_PKG_DESCRIPTION='A library for moving files and folders to the Recycle Bin' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE=MIT CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=trash CARGO_PKG_REPOSITORY='https://github.com/ArturKovacs/trash' CARGO_PKG_RUST_VERSION='' CARGO_PKG_VERSION=3.2.1 CARGO_PKG_VERSION_MAJOR=3 CARGO_PKG_VERSION_MINOR=2 CARGO_PKG_VERSION_PATCH=1 CARGO_PKG_VERSION_PRE='' CARGO_PRIMARY_PACKAGE=1 LD_LIBRARY_PATH='/tmp/tmp.SzDdY50d0n/target/debug/deps:/usr/lib' rustc --crate-name trash --edition=2021 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --emit=dep-info,link -C embed-bitcode=no -C debuginfo=2 --test -C metadata=b6cb85d25e0691b6 -C extra-filename=-b6cb85d25e0691b6 --out-dir /tmp/tmp.SzDdY50d0n/target/armv5te-unknown-linux-gnueabi/debug/deps --target armv5te-unknown-linux-gnueabi -C incremental=/tmp/tmp.SzDdY50d0n/target/armv5te-unknown-linux-gnueabi/debug/incremental -L dependency=/tmp/tmp.SzDdY50d0n/target/armv5te-unknown-linux-gnueabi/debug/deps -L dependency=/tmp/tmp.SzDdY50d0n/target/debug/deps --extern chrono=/tmp/tmp.SzDdY50d0n/target/armv5te-unknown-linux-gnueabi/debug/deps/libchrono-a07ba55d1ff87e6c.rlib --extern env_logger=/tmp/tmp.SzDdY50d0n/target/armv5te-unknown-linux-gnueabi/debug/deps/libenv_logger-e071735e7f2dda9c.rlib --extern libc=/tmp/tmp.SzDdY50d0n/target/armv5te-unknown-linux-gnueabi/debug/deps/liblibc-c5f67f71c4a920cd.rlib --extern log=/tmp/tmp.SzDdY50d0n/target/armv5te-unknown-linux-gnueabi/debug/deps/liblog-33aaff2d15946f52.rlib --extern once_cell=/tmp/tmp.SzDdY50d0n/target/armv5te-unknown-linux-gnueabi/debug/deps/libonce_cell-93276743d635398e.rlib --extern rand=/tmp/tmp.SzDdY50d0n/target/armv5te-unknown-linux-gnueabi/debug/deps/librand-853a2a9d1f3557a6.rlib --extern scopeguard=/tmp/tmp.SzDdY50d0n/target/armv5te-unknown-linux-gnueabi/debug/deps/libscopeguard-f68b495bfc4e3a5a.rlib --extern serial_test=/tmp/tmp.SzDdY50d0n/target/armv5te-unknown-linux-gnueabi/debug/deps/libserial_test-b36505b7a16018ec.rlib --extern tempfile=/tmp/tmp.SzDdY50d0n/target/armv5te-unknown-linux-gnueabi/debug/deps/libtempfile-2236c861b005ff52.rlib --extern url=/tmp/tmp.SzDdY50d0n/target/armv5te-unknown-linux-gnueabi/debug/deps/liburl-f30518ba9d857ee0.rlib -C debuginfo=2 --cap-lints warn -C linker=arm-linux-gnueabi-gcc -C link-arg=-Wl,-z,relro --remap-path-prefix /usr/share/cargo/registry/trash-3.2.1=/usr/share/cargo/registry/trash-3.2.1 --remap-path-prefix /tmp/tmp.SzDdY50d0n/registry=/usr/share/cargo/registry`
285s error[E0432]: unresolved import `std::sync::atomic::AtomicI64`
285s  --> src/tests.rs:3:29
285s   |
285s 3 |     use std::sync::atomic::{AtomicI64, Ordering};
285s   |                             ^^^^^^^^^
285s   |                             |
285s   |                             no `AtomicI64` in `sync::atomic`
285s   |                             help: a similar name exists in the module: `AtomicI32`
285s 
286s For more information about this error, try `rustc --explain E0432`.
286s error: could not compile `trash` due to previous error
Byron commented 8 months ago

Thanks for reporting!

I have created a new release which uses I32 for counting like proposed, and hope that works for you: https://github.com/Byron/trash-rs/releases/tag/v3.3.0 .

Closing, but please do reopen if anything else comes up or create a new issue.

tenzap commented 8 months ago

Unfortunately it is still falling:

363s    Compiling trash v3.3.0 (/usr/share/cargo/registry/trash-3.3.0)
363s      Running `CARGO=/usr/bin/cargo CARGO_CRATE_NAME=trash CARGO_MANIFEST_DIR=/usr/share/cargo/registry/trash-3.3.0 CARGO_PKG_AUTHORS='Artur Kovacs <kovacs.artur.barnabas@gmail.com>' CARGO_PKG_DESCRIPTION='A library for moving files and folders to the Recycle Bin' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE=MIT CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=trash CARGO_PKG_REPOSITORY='https://github.com/ArturKovacs/trash' CARGO_PKG_RUST_VERSION='' CARGO_PKG_VERSION=3.3.0 CARGO_PKG_VERSION_MAJOR=3 CARGO_PKG_VERSION_MINOR=3 CARGO_PKG_VERSION_PATCH=0 CARGO_PKG_VERSION_PRE='' CARGO_PRIMARY_PACKAGE=1 LD_LIBRARY_PATH='/tmp/tmp.5EklAGwQHC/target/debug/deps:/usr/lib' rustc --crate-name trash --edition=2021 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --emit=dep-info,link -C embed-bitcode=no -C debuginfo=2 --test -C metadata=c469760907a94006 -C extra-filename=-c469760907a94006 --out-dir /tmp/tmp.5EklAGwQHC/target/armv5te-unknown-linux-gnueabi/debug/deps --target armv5te-unknown-linux-gnueabi -C incremental=/tmp/tmp.5EklAGwQHC/target/armv5te-unknown-linux-gnueabi/debug/incremental -L dependency=/tmp/tmp.5EklAGwQHC/target/armv5te-unknown-linux-gnueabi/debug/deps -L dependency=/tmp/tmp.5EklAGwQHC/target/debug/deps --extern chrono=/tmp/tmp.5EklAGwQHC/target/armv5te-unknown-linux-gnueabi/debug/deps/libchrono-a07ba55d1ff87e6c.rlib --extern env_logger=/tmp/tmp.5EklAGwQHC/target/armv5te-unknown-linux-gnueabi/debug/deps/libenv_logger-b3af270f926bfd9a.rlib --extern libc=/tmp/tmp.5EklAGwQHC/target/armv5te-unknown-linux-gnueabi/debug/deps/liblibc-c5f67f71c4a920cd.rlib --extern log=/tmp/tmp.5EklAGwQHC/target/armv5te-unknown-linux-gnueabi/debug/deps/liblog-33aaff2d15946f52.rlib --extern once_cell=/tmp/tmp.5EklAGwQHC/target/armv5te-unknown-linux-gnueabi/debug/deps/libonce_cell-93276743d635398e.rlib --extern rand=/tmp/tmp.5EklAGwQHC/target/armv5te-unknown-linux-gnueabi/debug/deps/librand-853a2a9d1f3557a6.rlib --extern scopeguard=/tmp/tmp.5EklAGwQHC/target/armv5te-unknown-linux-gnueabi/debug/deps/libscopeguard-f68b495bfc4e3a5a.rlib --extern serial_test=/tmp/tmp.5EklAGwQHC/target/armv5te-unknown-linux-gnueabi/debug/deps/libserial_test-b36505b7a16018ec.rlib --extern tempfile=/tmp/tmp.5EklAGwQHC/target/armv5te-unknown-linux-gnueabi/debug/deps/libtempfile-2236c861b005ff52.rlib --extern url=/tmp/tmp.5EklAGwQHC/target/armv5te-unknown-linux-gnueabi/debug/deps/liburl-710613fc02e76d80.rlib -C debuginfo=2 --cap-lints warn -C linker=arm-linux-gnueabi-gcc -C link-arg=-Wl,-z,relro --remap-path-prefix /usr/share/cargo/registry/trash-3.3.0=/usr/share/cargo/registry/trash-3.3.0 --remap-path-prefix /tmp/tmp.5EklAGwQHC/registry=/usr/share/cargo/registry`
363s error[E0432]: unresolved import `std::sync::atomic::AtomicI64`
363s  --> src/tests.rs:3:29
363s   |
363s 3 |     use std::sync::atomic::{AtomicI64, Ordering};
363s   |                             ^^^^^^^^^
363s   |                             |
363s   |                             no `AtomicI64` in `sync::atomic`
363s   |                             help: a similar name exists in the module: `AtomicI32`
363s 
364s For more information about this error, try `rustc --explain E0432`.
364s error: could not compile `trash` due to previous error
364s 
364s Caused by:
Byron commented 8 months ago

I should have searched for all occurrences instead of relying on the compiler to not abort after the first issue.

https://github.com/Byron/trash-rs/releases/tag/v3.3.1 has been released, now all of these are gone and I hope nothing new shows up 😁.