search

ByronChen / html5media

Automatically exported from code.google.com/p/html5media
0 stars 0 forks source link

preload="auto" check should be case-insensitive #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The fix for issue 4 has this change:

autoBuffering: hasAttr(video, "autobuffer") || (hasAttr(video, "preload") 
&& (preload == "" || preload == "auto")),

The check for the attribute value needs to be case-insensitive.

Suggested fix

/^(|auto)$/i.test(preload)

Original issue reported on code.google.com by zcor...@gmail.com on 15 Mar 2010 at 6:06

GoogleCodeExporter commented 9 years ago 
Um... it's already case insensitive:

Line 173: var preload = (video.getAttribute("preload") || "").toLowerCase();

The value is forced to lower case, then checked agains lower-case strings.

Original comment by david.et...@gmail.com on 15 Mar 2010 at 9:34