search

Byrth / Lua-Byrth

Lua Addons and Scripts
3 stars 2 forks source link

Shortcuts - /pet Somersault <me> does not work when using new HeadbreakerKen pet #324

Closed mike-tesch closed 9 years ago

mike-tesch commented 9 years ago

Verified by loading/unloading just Shortcuts. I get "...A command error occurred." when using it from the menu or by typing. If I unload it he uses the ability.

Byrth commented 9 years ago

Hmm... I think I see what the problem is but I will need to restructure shortcuts in order to fix it and I'm not sure I have time right now. >:/

Byrth commented 9 years ago

Apparently I lied. I woke up early this morning and finished the conversion. It is on -dev now.

Here is a link to the new version (zipped up) if you want to try it out on live: https://www.dropbox.com/s/u0rtev3j3mo4aq0/shortcuts.zip?dl=0

mike-tesch commented 9 years ago

It works now if I use /pet Somersault , but not if I use it through the Abilities>Pet Command>Ready menu

I get

pet "Somersault " 24312 ....A command error occured.

Might be that extra space there

Byrth commented 9 years ago

The extra space shouldn't be there and it is likely causing the problem. Try deleting the space from the english name in your resources file (windower/res/job_abilities.lua :: entry #772) and see if that works then.

Windower unpacks ability names directly out of the .dats, so the mistake would be on on SE's end in a sense. However, this isn't the first time that they've made this mistake (iirc the Naja trust had a similar problem when she was introduced), so I can add a filter that just eliminates trailing spaces from names.

Byrth commented 9 years ago

This should be fixed on -dev.