search

Byrth / Lua-Byrth

Lua Addons and Scripts
3 stars 2 forks source link

GearSwap - Item Use still #352

Open Byrth opened 9 years ago

Byrth commented 9 years ago

https://github.com/Windower/Issues/issues/653

Basically, I don't know when to send which outgoing item packet. I thought I did, but apparently I don't. Need to fix it.

Byrth commented 9 years ago

Summary thus far: There's nothing I can see in the extra item data that indicates whether it should use the 0x36 or 0x37 packet, which is consistent with the same item using different packets in different circumstances. https://github.com/Byrth/Lua-Byrth/issues/306

Alternatives: It's possible that the packet the item uses is determined by the flags of its target. This could take a while to track down.

thecuriousorange commented 8 years ago

is this the same issue where it equips my magic precast set whenever I use an item? happens across multiple lua files that have nothing handling items.

Byrth commented 8 years ago

No, that should not happen.

GearSwap only handles /item "item name" <target>, but it does pass the item in to the same events as magic, abilities, wses, etc. If your rules in those events are causing something to be equipped (which sounds like what is happening) then it would be equipped.

Byrth commented 6 years ago

This problem would be addressed by this, but I can't figure out what distinguishes the packets: https://github.com/Byrth/Lua-Byrth/issues/306

Ivaar commented 6 years ago

I have not observed 0x036 being used on player or monster targets, only for NPCs the game allows you to open a trade window with. I'm fairly certain this packet is exclusive to NPCs with spawn_type 2 (trusts need verification as you can open a trade window with them also). However, enchanted equipment always produced 0x037 when the item was equipped and ready.

Byrth commented 6 years ago

I remember harvesting being an edge case.

Ivaar commented 6 years ago

I found it to be all usable items for NPC/object targets. For instance, can't use commands to trade apples at the racetrack or feed chocobo with gearswap loaded. I think I even had problems trading thief tools to treasure caskets. Basic rule I have found if it can be traded to NPC via menu the client will generate 0x36 everytime(except in the case of enchanted equipment as described above).

Byrth commented 6 years ago

Okay, I made the change on -dev now. The spawn_type == 2 filter works for everything I have tried.

vpmarche commented 6 years ago

this /raw /input "Hatchet" that someone mentioned, do you type that in a macro? and how does it work?