search

Byrth / Lua-Byrth

Lua Addons and Scripts
3 stars 2 forks source link

Battlemod: Cover #370

Closed MartelRagnarok closed 6 years ago

MartelRagnarok commented 9 years ago

I dunno if this is something you can do anything about, but I thought I'd ask.

Way back when, any attacks redirected by cover, would have a Cover! prefix in the log. This was very useful, as it told you if the coveree still had hate. But now only redirected WS(and maybe spells?) get a Cover! prefix. No idea why SE did that.

Anyway, I was wondering if there was still a cover, umm., flag/marker on packets for redirected attacks. And if battlemod could restore the Cover! prefix.

Obviously not hugely important considering the niche usefulness of cover. But would still be nice when you do use it. Should you decide to look into this, let me know if there's any testing or such I can assist with.

Byrth commented 9 years ago

Does Cover! even work with Battlemod? I don't see anywhere that I implemented it.

MartelRagnarok commented 9 years ago

I'm honestly not sure. I haven't covered any WS/spells since I started using BM regularly.

The behavior I described is that of the normal FFXI log in regards to cover.

Byrth commented 9 years ago

I'm pretty sure that it doesn't work. I have no idea how Cover! procs actually work. I'll have to look into it before my mule deactivates in a few days.

MartelRagnarok commented 7 years ago

Minor update. Ive been retesting Cover, and took a look at chat log mechanics while I was at it.

With battlemod unloaded the Cover! message still works on Critical hits, Ranged attacks, Spells, and WS. With battlemod loaded none of these show.

Is there some way I could test the packets for these to get you info on how to integrate this? I'm not great with packet code.

Byrth commented 7 years ago

I'll go do it right now, actually. I've been putting this off for far too long, lol

Byrth commented 7 years ago

Okay, I added it to -dev. Here is the file you have to replace: https://www.dropbox.com/s/6ot60im9eab82h9/parse_action_packet.lua?dl=0

Let me know if you see any problems.

MartelRagnarok commented 7 years ago

I'll test it once I get home.

MartelRagnarok commented 6 years ago

Wow.... Did I Seriously leave this here for over a year after telling you I'd test it when I got home? I didn't PM you or anything did I? I suck.

Can confirm that on the current dev version the following actions get a cover message. Melee Missed melee Ranged attack Missed ranged attacks Missed WS Spells

I tested on low level mobs, so they never landed a WS. I assume it works. Also assuming crits work. Thanks for fixing this and sorry for letting the issue languish here for so long.