ByrumLab / proteoDA

GNU General Public License v3.0
11 stars 11 forks source link

Qc report heatmap #237

Closed tjthurman closed 1 year ago

tjthurman commented 1 year ago

This PR address one of the reviewer comments for the JOSS manuscript. It modifies the QC report (write_qc_report()) to make them a little nicer and easier to read:

  1. When there are > 50 samples, the output files are now dynamically sized (with a minimum), to avoid issues of label overlap when there are many samples.
  2. For all plots, there is some updated handling of sample labels: labels that are longer than 20 characters are truncated (with a warning), and the code checks for non-unique sample labels (generates an error if they aren't unique). This allows us to handle plot sizing with some known label size constraints and avoid labels running over plot edges or over legends. When necessary, we also do some dynamic margin sizing based on the length of the longest label, to doubly-ensure no label overruns.
  3. Font sizes for all legends are increased in size, to make them a little easier to read.
  4. All PDF outputs have been made a little bigger, for readability.

This PR also contains new tests for the QC report, and fixes a bug in the other test code that allowed some empty test folders ot hang around.