search

Byte-Masons / Reliquary

50 stars 20 forks source link

Reliquary code review - function parameters #15

Closed jaetask closed 2 years ago

jaetask commented 2 years ago

Consistent function parameter naming convention

There are many places in the Reliquary where function parameters are like pid, positionId, amount etc and sometimes they are _pid, _amount, _positionId. There are also cases where a single function contains mixed conventions in a single line.

function myFunction( uint256 _pid, uint256 positionId)

This PR renames all input parameters with the _ prefix for consistency. All tests pass but please double check my conversions.

jaetask commented 2 years ago

That seems crazy. so if I add a global variable I have to rename function params and change existing code?