search

Byte-Masons / Reliquary

50 stars 20 forks source link

Unused function parameters #25

Closed lootboi closed 1 year ago

lootboi commented 2 years ago

Screenshot 2022-09-28 112049

When compiling, there are numerous unused function parameters. Will these have some usage in the future or can they just be removed?

Zokunei commented 2 years ago

The parameters are passed to the interfaces so that overriding contracts can take advantage of them for added functionality. It is not envisioned for there to be only one implementation of a Rewarder, NFTDescriptor, or EmissionCurve.

Zokunei commented 1 year ago

Issue addressed in commit 2340a00.