search

Byte-Masons / Reliquary

50 stars 20 forks source link

Adding support to husky #5

Closed StErMi closed 2 years ago

StErMi commented 2 years ago

Another 2 cents, it's not cool to have commits that do not build/fail tests that have been merged with code.

https://www.npmjs.com/package/husky allows you to create automation before commit/push.

In this case husky can be used to attach some automation before commit/push like:

if some of these commands fail with warning/error the command (commit/push) fails.

I've never done this for a solidity project but I don't think it's a difficult task. Another option would be to attach all these checks on the CI pipeline of git but I think that it's a second step that should be done after being sure that your local code does not fail.

0xBebis commented 2 years ago

this would be extremely convenient, again leaving in the hands of you and @Zokunei - I'll let him make the final call as to whether it would be necessary. @jaetask and @tess3rac7 could maybe add their own 2 cents on the matter

jaetask commented 2 years ago

Yes, this is planned, thank you for reminding me.

Zokunei commented 2 years ago

addressed in commit 500f72ab12351f87606d48f99f0b3f8859580e04