Token we're giving out == OATH
NFT that represents stake == Relic
~Shrine~ Reliquary
This PR simply updates the naming throughout the Reliquary contract (and related interface) to be consistent with the above. There is a lot of scope for improving naming of data types and I am leaving TODOs as I am going along (while I passively brainstorm and offer some suggestions that we can collectively agree on).
With clear and consistent naming it should be easier for any of us to start following the logic in each of the functions without too much confusion--which is what I plan to do next with this code:
Examine the logic in each of the functions
See if there is any opportunity to make the logic clearer or more concise
As a result of this process hopefully revisit my naming-related TODOs to come up with solid names for our data types.
Token we're giving out == OATH NFT that represents stake == Relic ~Shrine~ Reliquary
This PR simply updates the naming throughout the Reliquary contract (and related interface) to be consistent with the above. There is a lot of scope for improving naming of data types and I am leaving TODOs as I am going along (while I passively brainstorm and offer some suggestions that we can collectively agree on).
With clear and consistent naming it should be easier for any of us to start following the logic in each of the functions without too much confusion--which is what I plan to do next with this code: