Saw in commit 142d789 that the getters and setters for x & y position values had been made lowercase. I think they should remain uppercase for a few reasons:
It is not inline with the style of all other methods of the class, including its other getters and setters
It avoids confusion, since it may be difficult to always be sure what is being called/not called
avoids potential mixups where a function might be passed or called where we want to access a variable
I think there are are a few potential solutions:
rename all getters & setters to get$VAL and set$VAL, to completely avoid the problem of getters & setters sharing similar names with their variables
recapitalize the x() and y() getters and setters. It brings them in line with every other method that the UiElement class uses
The formatting of methods in general can also be discussed here too, just so that we can clear up how we write their names overall.
Saw in commit 142d789 that the getters and setters for x & y position values had been made lowercase. I think they should remain uppercase for a few reasons:
I think there are are a few potential solutions:
The formatting of methods in general can also be discussed here too, just so that we can clear up how we write their names overall.