ByteArena / ba

Byte Arena CLI
https://doc.bytearena.com
Other
17 stars 1 forks source link

Add the ability to expose custom port of the agent #3

Closed johnsudaar closed 6 years ago

johnsudaar commented 6 years ago

It would be nice if the BA trainer can export some port of the agent (if you have an http server used for debugging) or if you want to make a remote controlled agent to train your "real agent"

netgusto commented 6 years ago

There's the -port command line flag that's supposed to achieve that. Or maybe I dont get it?

netgusto commented 6 years ago

ok got it: some port OF the agent. Nevermind my previous comment.

johnsudaar commented 6 years ago

Yep! Launching the container with -P, so we can define some exposed port in our Dockerfile: https://docs.docker.com/engine/reference/builder/#expose

xtuc commented 6 years ago

That's ^ a good solution. On the trainer we allow these kind of Dockerfile instruction but online they will be forbidden.

We're going to consider doing something like that, thanks.

xtuc commented 6 years ago

Instead of the agent exposing a port/server, it can connect to whatever service you created.

Note that it will only be available in the trainer. @johnsudaar can we close this?

netgusto commented 6 years ago

Agent calling the host rather than the opposite: LGTM.

Especialy since many agents could connect to the same service.

netgusto commented 6 years ago

ping @johnsudaar