search

ByteBuildersLabs / ByteBeastsFrontend

MIT License
2 stars 16 forks source link

feat: Added motion animations for flowers #100

Closed CristopherAguilar10 closed 3 weeks ago

CristopherAguilar10 commented 4 weeks ago

Closes #93

This pull request adds animations for the flowers, specifically for the blue flower and the white flower. The animations add a more dynamic visual effect to the environment.

Changes made:

Animations created:

  1. Two animations were created for the blue flowers (BlueFlowerAnim.anim and FlowerAnim.anim). The blueFlowerAnim: has the animation of the falling petals, and the FlowerAnim: has a basic animation for the blue flowers.

  2. An animation was created for the white flowers (WhiteFlower.anim), a basic animation of movement for the white flowers.

    1. Added animations for the blue flower (RA_Jungle_231) and the white flower (RA_Jungle_223), with smooth movements that simulate the effect of the wind.

    Project structure:

  1. FlowerAnimation/Animations: contains the animation clips for the flowers.
  2. FlowerAnimation/Controllers: includes the Animator Controllers configured to handle the animations.
  3. FlowerAnimation/Sprites: stores the sprites used in the animations.

New Animator Controllers:

  1. Specific Animator Controllers were created for each type of flower:
  2. FlowerBlue.controller: controls the basic animations for blue flowers.
  3. FlowerWhite.controller: handles animations for white flowers.
  4. FlowersPetals.controller: an additional controller to manage petal-specific animations.

Viewing the animations:

WhiteFlower

Summary by CodeRabbit

jimenezz22 commented 4 weeks ago

@CristopherAguilar10 can you provide a detailed summary about the pr please.

coderabbitai[bot] commented 4 weeks ago

Walkthrough

The pull request introduces a series of new assets and metadata files related to flower animations in a Unity project. It includes several animation clips, such as BlueFlowerAnim.anim, FlowerAnim.anim, WhiteFlower.anim, and others, each defined in YAML format with properties like sample rate and looping behavior. Corresponding metadata files are created for each animation, specifying unique identifiers (GUIDs) and import settings. Additionally, new animator controllers are established, including FlowerBlue.controller, FlowerWhite.controller, and PetalsV2Controller.controller, which define states and parameters for the animations. The changes also encompass new texture assets for the flowers, complete with detailed metadata files that outline texture import settings and sprite configurations. Overall, the modifications aim to enhance the visual representation of flowers in the Unity scenes by providing a structured approach to animation and asset management.

Assessment against linked issues

Objective Addressed Explanation
Animate the flowers (93) ✅
Ensure animations reflect wind movement (93) ✅

Suggested reviewers

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
jimenezz22 commented 4 weeks ago

@CristopherAguilar10 can you provide a gameplay gif for the other reviewers have a perspective about how flowers looks

jimenezz22 commented 4 weeks ago

@RolandoDrRobot @juandiegocv27 pr already tested on my local repo and successfully works

jimenezz22 commented 3 weeks ago

Please make animations for the flowers in the town scene as I told you in telegram dm

this should be another issue

jimenezz22 commented 3 weeks ago

@CristopherAguilar10 I will merge this pr tomorrow

CristopherAguilar10 commented 3 weeks ago

Ok @jimenezz22, thank you for the opportunity to contribute