search

ByteByteGoHq / system-design-101

Explain complex systems using visuals and simple terms. Help you prepare for system design interviews.
https://blog.bytebytego.com/
Other
62.95k stars 6.55k forks source link

Fix: Replaced typos in some images #29

Open AmineAouragh opened 10 months ago

AmineAouragh commented 10 months ago

This is a fix to the issue #24 that says that in the rest vs graphql picture there was a typo where 'Micorservices' should be 'Microservices'

Here is the current image used with the typo

graphQL (1)

and here is the image with the fixed typo

graphQL

AmineAouragh commented 10 months ago

Fixed another typo signaled by issue #30 in the CI/CD Pipeline image.

Since i committed to my same branch fix-typo i couldn't create a new pull request so I am commenting here

AmineAouragh commented 10 months ago

Fixed another typo signaled by issue #37 in the Monorepo vs Microrepo image

salvadorgonmo commented 10 months ago

Wondering, how do you usually fix typos on images? @ AmineAouragh

Just wondering how to do it so I can start my own contributions here as well.

Thanks!

AmineAouragh commented 10 months ago

Hey @salvadorgonmo yeah sure

i use Canva to remove the typo and replace with a word, making sure to find the closest font possible to the one in the image

matheusaraujo commented 10 months ago

Nice work, @AmineAouragh! But, according to the CONTRIBUTING, I believe you should open an issue for fixing diagrams.

If you notice typos or issues in diagrams, please open a separate issue instead of fixing the images directly. We will update the source images and republish fixes.

https://github.com/ByteByteGoHq/system-design-101/blob/main/CONTRIBUTING.md