search

ByteByteGoHq / system-design-101

Explain complex systems using visuals and simple terms. Help you prepare for system design interviews.
https://blog.bytebytego.com/
Other
62.48k stars 6.49k forks source link

git rebase diagram correct? #34

Open Bascy opened 10 months ago

Bascy commented 10 months ago

I think the git rebase diagram is not correct:

After rebasing the feature branch on master, the master branch does not change (still pointing to D), and feature branch is still pointing to G.

Commit E is now based on D in stead of B which is already correct in the diagram

macie commented 10 months ago

@Bascy you are right. Rebase changes "base commit" of feature branch, without merging feature branch to main branch.