search

ByteCrafter / Craftbyte-Mod-IDE

Craftbyte Mod IDE - An Minecraft Mod IDE for Minecraft Mod Developers -
http://bytecrafter.github.io/Craftbyte-Mod-IDE/
6 stars 2 forks source link

Redo 'PrjSolutionFileWriter' #15

Closed lewisakura closed 8 years ago

lewisakura commented 8 years ago

Redo 'PrjSolutionFileWriter' to use arguments instead of variables out of a different class. Please reference line 11. You will need to redo how it writes the file.

ByteCrafter commented 8 years ago

Okay, i will test it. I wanted anyways to change it like you did.

lewisakura commented 8 years ago

Also, it's good practice to use arguments instead of dragging them out of another class.

ByteCrafter commented 8 years ago

Yeah, will merge pull request.

lewisakura commented 8 years ago

Thank you.

ByteCrafter commented 8 years ago

PS: Why did you forked the Repo? (Just an question :D)

lewisakura commented 8 years ago

That's how pull requests work. When you want to commit, you fork it and then submit a pull request. A contributor will then pull it and the commiter can delete the fork.

ByteCrafter commented 8 years ago

Ahh, okay.

lewisakura commented 8 years ago

All done. Thank you for pulling.

ByteCrafter commented 8 years ago

Okay. And no problem! :)

lewisakura commented 8 years ago

:)