search

ByteGain / scrollmagic

The javascript library for magical scroll interactions.
http://ScrollMagic.io
Other
0 stars 1 forks source link

Fix imports for Webpack #4

Closed atav32 closed 6 years ago

atav32 commented 6 years ago

Like this: https://github.com/janpaepke/ScrollMagic/pull/684

So that people don't have to keep doing this https://github.com/janpaepke/ScrollMagic/issues/324#issuecomment-382591182 and this https://github.com/janpaepke/ScrollMagic/issues/685#issuecomment-314771153

atav32 commented 6 years ago

A couple things to remember for the future

1) everything's easier when the module name and all imports reference a lowercase name a) changed "ScrollMagic" to "scrollmagic" (except the class name) 2) ES6 imports work better when ScrollMagic references the UMD versions of GSAP TweenMax 3) still need a Webpack/Babel alias to help animation.gspa.js find the module scrollmagic and point it to scrollmagic.js