search

BytezoTeam / Eventfully

https://eventfully.ugolis.de/
GNU General Public License v3.0
4 stars 2 forks source link

build(docker): use tini #69

Closed kaindlnetwork closed 5 months ago

kaindlnetwork commented 5 months ago

Add Tini in Docker Image. This ensures proper process signal handling. It is included in Dockerfile rather than Docker-Compose to have some backwards compatability for old Container Runtimes

2mal3 commented 5 months ago

I will merge but are 7 year old Docker versions still that common?

kaindlnetwork commented 5 months ago

Hi there,

a) As long as there are still Windows-NT Admins consider every old version as possible. It is nice for long term stability to support it when it does not cost much maintenance. b) Most Admins forget setting init option in docker compose and therefore it is easier to implement it right into the image to ensure that everything works as expected. An Example is linuxservers with their (overengineered) s6 init system. c) Always expect that a container might gone rough and ignore any signal handling. hust Java Programms from Hell hust

Best Regards

Fabian