Bytezz / IPLookup-gtk

Find info about an IP address.
GNU General Public License v3.0
21 stars 11 forks source link

Better appstream screenshots #26

Closed bertob closed 8 months ago

bertob commented 9 months ago

Flathub has new app metadata guidelines, which this app is already in line with except for a few minor issues with the screenshots:

This blog post has a bit more context on the curation initiative: https://docs.flathub.org/blog/quality-moderation

Bytezz commented 9 months ago

Thanks @bertob for reporting. Lately I've been a bit of touch so I've missed these new guidelines. Will comply as soon as I have time.

Anyway, I would like to point out that, since there are a LOT of different default configurations on a LOT of different distros, maybe windows' title buttons position should not concern that much. But I understand the motivation.

bertob commented 9 months ago

Anyway, I would like to point out that, since there are a LOT of different default configurations on a LOT of different distros

That's why we specify that it's the platform default, rather than the distro. There are thousands of distros, but only a handful of app platforms (GNOME, KDE, elementary), and unlike with distros there is a single clear default there :)

Bytezz commented 9 months ago

That's why we specify that it's the platform default, rather than the distro.

Ok, that makes sense.

Going back to screenshots, are half dark/light theme screenshots ok? iplookup-1

bertob commented 9 months ago

No, screenshots should be not be edited. You can include one or two extra screenshots in dark to show that it's supported, but otherwise just use the default (light).

By the way, your example here is a bit too small, I'd try to go as close to 1000x700 as possible (maybe a bit narrower in this case since it's just a single list, e.g. 700x700 or so?).

Bytezz commented 8 months ago

Sorry for late response (I'm on vacation). What about these? Screenshot from 2024-02-10 17-53-22 Screenshot from 2024-02-10 17-53-31

These are very close to 700x700px (698x605px with shadows)

bertob commented 8 months ago

Would be even better without visible scrollbars, but looks great otherwise!

Bytezz commented 8 months ago

Closed by a78591a8b762b7eb00de956f792ab197061fa74c

bertob commented 8 months ago

Just realized that the window controls are non-default (close button should be on the right), sorry for not catching this earlier :disappointed:

Bytezz commented 8 months ago

Don't worry, I've noticed it as soon as I pushed the commit. Force pushed amended commit right after.