search

ByzantineFailure / BPM-for-Discord

BPM for Discord's Desktop App. Includes one-click installers, update notifications, and custom script support.
GNU Affero General Public License v3.0
17 stars 8 forks source link

Allows usage of '-consent' to bypass asking for user consent #54

Closed bloons3 closed 8 years ago

bloons3 commented 8 years ago

'-consent' will bypass asking the user to choose to install NodeJS and will automatically install

ByzantineFailure commented 8 years ago

This resolves an issue that could be avoided by having node 4.2.x on the PATH or running index.js with a local version of node (this confirmed works with all versions from 4.2-current). I also see very little use for this outside of automation.

If you already have node on your PATH, you actually don't need to run the .bat or .ps1 files at all. All those exist to do is to:

  1. Download Node 4.2.x
  2. Run node.exe index.js . in the extracted archive's directory with the binary that was downloaded
  3. Delete the binary that was downloaded

It is a much, much better idea to just put Node on your path if you are automating. I think for now I'm going to close this without merging as it resolves a problem that already has a known workaround.

As a note, if you have a different Node install on your path already I'd recommend using something like nvm-windows to manage it.

ByzantineFailure commented 8 years ago

Side note, if this really is a feature that's desired for something other than automation, I will reconsider this PR.

For now, if someone is technically adept enough to automate the installation process I feel it's not too much of an ask to have them put node on their PATH.