install_linux.sh assumes curl is installed, and does not exit gracefully when not installed.

ByzantineFailure / BPM-for-Discord

BPM for Discord's Desktop App. Includes one-click installers, update notifications, and custom script support.

GNU Affero General Public License v3.0

17 stars 8 forks source link

install_linux.sh assumes curl is installed, and does not exit gracefully when not installed. #63

Closed CrystalSplitter closed 7 years ago

CrystalSplitter commented 7 years ago

The file install_linux.sh should run type curl or command -v curl and check for a return status of 0 ensure that it is installed instead of just assuming it ran properly.

It looks like a simple fix from my side, but I can't say I'm too familiar with setup the repository has currently, and would rather not contribute a "fix" that would end up introducing new bugs.

ByzantineFailure commented 7 years ago

Can you look this over and see if it looks good?

https://github.com/ByzantineFailure/BPM-for-Discord/pull/64

ByzantineFailure commented 7 years ago

Tried to ensure all the things got redirected to the right places. Also, what distro are you using? I've actually never used one that doesn't come with curl preloaded, although I suspect Arch probably doesn't.

ByzantineFailure commented 7 years ago

Also, I feel kind of sheepish for assuming it existed on all installs. I'm just so used to it being there. Good catch.

CrystalSplitter commented 7 years ago

It works on my end!

Debian Stretch. I started out with the minimal install (server style install) and then built the DE up from there. I just realised today I didn't have it installed.

ByzantineFailure commented 7 years ago

Closed via #64