search

ByzantineFailure / BPM-for-Discord

BPM for Discord's Desktop App. Includes one-click installers, update notifications, and custom script support.
GNU Affero General Public License v3.0
17 stars 8 forks source link

Settings tab not showing up in main settings menu (BPM for BD) #65

Closed Kekerin0 closed 7 years ago

Kekerin0 commented 7 years ago

Everything else about the plugin seems to work. I can search and add emotes. The sbstare is displayed at the bottom of my servers. But I can not change any settings because the settings tab is gone

image

Shugabuga commented 7 years ago

Are you using macOS or Windows? macOS has two ways to enter Settings, and I recall one used to be broken until recently (so maybe it broke again?).

ByzantineFailure commented 7 years ago

Blech, okay, looks like I'm gonna have to install BD and try to figure out why this is happening. grumble

Note, this happens on Windows BD as well.

ByzantineFailure commented 7 years ago

From what I can tell this is due to a change in BetterDiscord -- I think it actually does some re-naming or... something of the entire settings modal which prevents BPM's `MutationObserver from functioning.

ByzantineFailure commented 7 years ago

Confirmed. I kept the old button-listener-based implementation around in comments and it seems to have paid off -- definitely works with BD when I don't use the MutationObserver. Unfortunately reverting to that implementation means that the Mac Preferences selector is broken for vanilla BPM and I'm not willing to break vanilla BPM for BD.

So, I need to figure a thing to listen on for BD specifically, and it's likely going to impact performance. Neat.

Side note, I'm getting real sick of BD continually breaking shit.

ByzantineFailure commented 7 years ago

Fixed via 07295325d1595d8625d46ef8666f3e63f5558193

I'm not going to push this out immediately. Given the rate at which BD has been breaking shit lately I want to wait at least a week to see if anything else breaks before pushing out a BD-specific pre-release.

This issue will remain open until a release is pushed out.

ByzantineFailure commented 7 years ago

Released. Closing.