ByzantineFailure / BPM-for-Discord

BPM for Discord's Desktop App. Includes one-click installers, update notifications, and custom script support.
GNU Affero General Public License v3.0
17 stars 8 forks source link

add ability to add other subreddits to the list emotes are pulled from (like core BPM) #75

Closed jamesmanning closed 7 years ago

jamesmanning commented 7 years ago

@ByzantineFailure I think this is different than #19 but if I'm wrong, please close as a duplicate. 😄

In the BPM settings it's listed as 'Custom Subreddits' but I wasn't sure if the BPM for Discord would need to treat user-added subreddits any different than the default list, so hoping this is possible. Is BPM for Discord more restricted than the BPM extension because it runs in a frame?

image

ByzantineFailure commented 7 years ago

This is unfortunately not possible because reddit is pretty picky about where it will allow its stylesheets to be loaded from. BPM's core emotes get around this by just building custom stylesheets for its own use, but pulling subreddits will not be possible on Discord. Sorry :(

jamesmanning commented 7 years ago

@ByzantineFailure is there any other option for importing 'external' emotes? i've already got those other emotes in a json file, so if there's either a place i could write a file (whatever structure you preferred) or some other way of getting them in, that'd be great. It certainly doesn't need to be scraping random subreddits, I can completely understand that being problematic. 😄

ByzantineFailure commented 7 years ago

The only thing I can think of is the custom JS support that is there. You can write JS files which will be executed in the browser context:

https://github.com/ByzantineFailure/BPM-for-Discord/blob/discord-v0.9.1-beta/discord/CUSTOMJS.md

You would need to distribute the file you create to the others who would use it, but it's doable -- just create a file that loads some CSS as a static string and throws it on the page as a <style> tag.

It's not great but in the absence of the ability to retrieve CSS from reddit it's what I've got.