ByzantineFailure / BPM-for-Discord

BPM for Discord's Desktop App. Includes one-click installers, update notifications, and custom script support.
GNU Affero General Public License v3.0
17 stars 8 forks source link

Does not convert html-ised markdown emotes in custom embeds #76

Closed Jibodeah closed 7 years ago

Jibodeah commented 7 years ago

So I admit this is a bit of a odd use case but in rich embeds (the type only creatable by bots) the markdown [link](format) actually works. So you can have a emote code in it and, sure enough, it's invisible to those without BPM.

Trouble is, it's also invisible to those with BPM. See images below...

Rich embed, with no emote visible

The html source of the embed, with the invisible link that the emote code produces visible

In theory it shouldn't be too hard to find and convert these emotes. ...It's what BPM itself does on reddit. It should probably only be done in the 'description' section of embeds too.

(...oh and while I probably could workaround this by escaping the emotes so they get rendered as their codes, that seems kinda messy)

ByzantineFailure commented 7 years ago

Hm. that's... quite niche. Nice, well-formed bug report, btw.

What's going on here seems to be that there's some conflict between the way things are parsed and handled outside reddit and inside reddit. Unsure what's up, will have to investigate.

ByzantineFailure commented 7 years ago

Can you link me to an example post I can use to play around?

ByzantineFailure commented 7 years ago

Reference emote please ignore

[](/ajwut)

ByzantineFailure commented 7 years ago

Changes made and successful. Will go out with the next update of BPM's core.